[Webkit-unassigned] [Bug 153356] Style resolver initialization cleanups

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 22 10:11:32 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153356

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269577|review?                     |review+
              Flags|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 269577
  --> https://bugs.webkit.org/attachment.cgi?id=269577
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269577&action=review

> Source/WebCore/css/StyleResolver.h:453
> -        EInsideLink m_elementLinkState;
> +        EInsideLink m_elementLinkState { NotInsideLink };
>  
> -        bool m_elementAffectedByClassRules;
> +        bool m_elementAffectedByClassRules { false };
>  
> -        bool m_applyPropertyToRegularStyle;
> -        bool m_applyPropertyToVisitedLinkStyle;
> +        bool m_applyPropertyToRegularStyle { true };
> +        bool m_applyPropertyToVisitedLinkStyle { false };
>  
>          PendingImagePropertyMap m_pendingImageProperties;
>  
>          Vector<RefPtr<ReferenceFilterOperation>> m_filtersWithPendingSVGDocuments;
>  
> -        bool m_fontDirty;
> -        bool m_fontSizeHasViewportUnits;
> +        bool m_fontDirty { false };
> +        bool m_fontSizeHasViewportUnits { false };
>  
> -        bool m_hasUAAppearance;
> +        bool m_hasUAAppearance { false };
>          BorderData m_borderData;
> -        FillLayer m_backgroundData;
> +        FillLayer m_backgroundData { BackgroundFillLayer };
>          Color m_backgroundColor;

Would be nice to pack all the bools and small enums together to save space.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160122/31923aea/attachment.html>


More information about the webkit-unassigned mailing list