[Webkit-unassigned] [Bug 153194] [GTK] maps.google.com unresponsive/stalls in 2.11.3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 21 08:33:44 PST 2016


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #6)
> (In reply to comment #5)
> ...
> > I don't think it's a matter of number of commits, we had a lot of commits in
> > this release because it took a bit more time since the laste release. All
> > commits landed are bug fixes, rendering issues, crashes and security bugs.
> > What should I leave out? I always try to avoid major refactorings, or large
> > changes in JSC. For every commit I merge, if it's JSC I run all the
> > javascript tests, if it's a rendering issue or crash referencing layout
> > tests I run those, and if it affects the GTK API I run the GTK API tests. I
> > could still merge a commit that breaks something or regresses, of course,
> > but that wouldn't change if I merged fewer commits.
> I agree it is not the number of commits but maybe the criteria could be
> slightly changed.
> What about only merging:
> * fixes of bugs reported to the stable branch.
> * security fixes
> * other kind of fixes that have been already merged in
> (current_unstable_version - 1) and no regressions have been reported on them.

That doesn't fix anything either, because for example in this particular case we don't know which commit in trunk broke maps.google.com. I prefer to fix 10 issues and introduce 1 regression than fixing 5 issues with no regressions. In any case I always try to avoid merging commits that have been recently committed in trunk, so I'm doing something similar already in the end.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160121/71b6757b/attachment.html>

More information about the webkit-unassigned mailing list