[Webkit-unassigned] [Bug 152913] Refactor compareIterations to remove duplicate code.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152913

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269395|review?                     |review+
              Flags|                            |

--- Comment #18 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 269395
  --> https://bugs.webkit.org/attachment.cgi?id=269395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269395&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:77
> +    iteration1.revision = {};

This is OK as-is. I meant to suggest explicitly specifying a repository revision.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:91
> +    iteration1.revision = {};
> +    iteration2.revision = {};

This is OK as-is. I meant to suggest explicitly specifying repository revisions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160121/c4bfd40e/attachment.html>