[Webkit-unassigned] [Bug 152913] Refactor compareIterations to remove duplicate code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 20 08:33:28 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=152913

--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 268981
  --> https://bugs.webkit.org/attachment.cgi?id=268981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268981&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:65
> +    iteration1.revision = { "openSource": 42 };

I suggest that we instantiate local BuildbotIterations in each test function, including this one, instead of modifying the "global" iteration instances. Shared objects between tests should be immutable and/or conveyed to be immutable. The benefit of using this approach and only sharing immutable data between tests is that it makes it straightforward to verify correctness.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160120/9e356ad7/attachment.html>


More information about the webkit-unassigned mailing list