[Webkit-unassigned] [Bug 153233] [GTK] Runtime critical warnings when loading a URL after a session restore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 08:48:28 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153233

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 269266 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=269266&action=review

Thanks for the review.

> > Source/WebKit2/ChangeLog:9
> > +        forward list form session state and the list contained forward
> 
> form -> from
> 
> > Source/WebKit2/ChangeLog:13
> > +        the back forward list is populated form session state, items are
> 
> form -> from
> 
> > Source/WebKit2/ChangeLog:16
> > +        removed from the list should have a wrapper already created.
> 
> Good job! :p

:-D It's seems I don't know how to type from.

> > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:378
> > +    // forward items doesn't produce any runtime critical warning. See bug #
> 
> See bug #153233.

I had already changed this, but forgot to save the files changes :-P

> > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:395
> > +    // A normal load after a session restore should remove the forward list, add the new item and updated the current one.
> 
> updated -> update

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160119/bdaef772/attachment-0001.html>


More information about the webkit-unassigned mailing list