[Webkit-unassigned] [Bug 150381] [MIPS] LLInt: fix calculation of Global Offset Table

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 18 01:31:46 PST 2016


--- Comment #7 from Julien Brianceau <jbriance at cisco.com> ---
Comment on attachment 269193
  --> https://bugs.webkit.org/attachment.cgi?id=269193

View in context: https://bugs.webkit.org/attachment.cgi?id=269193&action=review

LGTM, please just fix ChangeLog file

> Source/JavaScriptCore/ChangeLog:3
> +        llint: fix calculation of Global Offset Table

This line seems redundant with line 5, please remove it

> Source/JavaScriptCore/ChangeLog:14
> +        instruction setcallreg which does exactlly that.

exactlly -> exactly

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160118/3512ec5f/attachment.html>

More information about the webkit-unassigned mailing list