[Webkit-unassigned] [Bug 139342] Pending API Request URL is wrong after reloading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139342

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242716|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 242716
  --> https://bugs.webkit.org/attachment.cgi?id=242716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242716&action=review

I’m saying review+ but I am not 100% sure this is right.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:902
> +    String url = m_pageLoadState.activeURL();
> +    if (url.isEmpty() && m_backForwardList->currentItem())
> +        url = m_backForwardList->currentItem()->url();
> +
> +    if (!url.isEmpty()) {

Seems a little peculiar here to use isEmpty rather than isNull.

I’m generally concerned that this code is trying to figure out what URL the other process will reload; we are not sending the URL over, so this is trying to predict what the other process will do? If so, then it seems that to be correct this has to match the logic in FrameLoader::reload and other loader logic inside WebCore, and it seems to me that adding this one thing it’s still far from matching it! It’s nice to fix this one particular case, but what about:

- The case where there is an unreachableURL.
- If a window is created by javascript, its main frame can have an empty but non-nil URL. We need to test that case.

I’d like to hear Anders’s opinion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160115/a961e153/attachment-0001.html>