[Webkit-unassigned] [Bug 153040] WK2: Request completion candidates when needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153040

--- Comment #14 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #13)
> Comment on attachment 268909 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268909&action=review
> 
> > Source/WebKit2/Shared/EditorState.cpp:131
> > +#if PLATFORM(MAC)
> > +    encoder << candidateRequestStartPosition;
> > +    encoder << paragraphContextForCandidateRequest;
> > +    encoder << stringForCandidateRequest;
> > +#endif
> 
> EditorState is a very unfortunate hack which cannot possibly result in
> reliable behavior.
> 
> Does the API require synchronous return? Can we request making it
> asynchronous?

I was not aware that EditorState is considered a hack! I'm open to other ideas for the best way to implement this. The API does not require synchronous return, but we do need to request candidates on every selection change, and the analogous iOS API is implemented via EditorState, so it seems like a good place for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160114/cd4d1739/attachment.html>