[Webkit-unassigned] [Bug 151280] Web Inspector: Dashboard log message count doesn't include console.time messages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151280

--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
(In reply to comment #2)
> The problem is in `_incrementConsoleMessageType` in
> `Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js`, where it
> only increments log/issue/error-count if the ConsoleMessage has the levels
> log, warning, or error respectively.
> As there also exists MessageLevels info and debug, those are not included in
> the log-count.

The Chrome console API reference states that console.info and console.debug are identical to console.log, so it works for me!

> Adding two fallthrough cases for info and debug to also increment the
> log-count would solve the problem.
> This would make `console.timeEnd()`, `console.debug()`, and `console.info()`
> increment the log-count in the dashboard.
> 
> If that sounds like an okay solution, I’d like to submit a patch.

Sounds good.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160110/106c8115/attachment.html>