[Webkit-unassigned] [Bug 152759] SVG polyline and polygon leak page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152759

--- Comment #5 from Chris Vienneau <chris.vno at outlook.com> ---
I initially stated that polyline and polygon leak, I now believe in fact any svg node that creates a SVGAnimatedProperty will leak.  It just so happens that polyline and polygon always create it.  In older code based on based on 157437 the SVGAnimatedProperty would be created less often for polyline and polygon, additionally when it was created it didn't leak.

For now i'm using a workaround by restoring WebCore\rendering\svg\SVGPathData.cpp updatePathFromPolygonElement() and updatePathFromPolylineElement() to their older version in order to hit the failure case less often.  I'm also immediately releasing the reference kept on the "SVGElement* contextElement" in SVGAnimatedProperty constructor; so when the error case happens we don't leak the whole page (only the SVGAnimatedProperty).  

This greatly reduces the memory leaked and our soaks come out pretty good now. and I haven't encountered any issue with releasing the ref early.  I'm moving on to other more urgent issues for the time being, these workarounds I'm using i only consider temporary, I'd be interested in a better fix if one becomes available.

Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160108/e9e7f0c2/attachment.html>