[Webkit-unassigned] [Bug 152901] FTL B3 fails to realize that binary snippets might choose to omit their fast path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152901

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|webkit-unassigned at lists.web |fpizlo at apple.com
                   |kit.org                     |
 Attachment #268552|                            |review?
              Flags|                            |

--- Comment #1 from Filip Pizlo <fpizlo at apple.com> ---
Created attachment 268552
  --> https://bugs.webkit.org/attachment.cgi?id=268552&action=review
the patch

After this patch we only have a handful of test failures:

** The following JSC stress test failures have been introduced:
    jsc-layout-tests.yaml/js/script-tests/dfg-constant-fold-misprediction.js.layout-ftl-eager-no-cjit
    profiler-test.yaml/tests/sunspider-1.0/crypto-sha1.js.profiler
    regress/script-tests/call-spread-apply.js.ftl-no-cjit-no-inline-validate
    regress/script-tests/call-spread-call.js.ftl-no-cjit-no-inline-validate
    regress/script-tests/getter-richards-try-catch.js.default-ftl
    regress/script-tests/getter-richards-try-catch.js.ftl-no-cjit-validate
    regress/script-tests/richards-try-catch.js.default-ftl
    regress/script-tests/richards-try-catch.js.ftl-eager
    regress/script-tests/richards-try-catch.js.ftl-eager-no-cjit
    regress/script-tests/richards-try-catch.js.ftl-no-cjit-no-put-stack-validate
    regress/script-tests/richards-try-catch.js.ftl-no-cjit-validate
    regress/script-tests/varargs-strict-mode.js.ftl-no-cjit-no-inline-validate
    stress/ftl-try-catch-oom-error-lazy-slow-path.js.default-ftl
    stress/ftl-try-catch-oom-error-lazy-slow-path.js.ftl-eager
    stress/ftl-try-catch-oom-error-lazy-slow-path.js.ftl-eager-no-cjit
    stress/ftl-try-catch-oom-error-lazy-slow-path.js.ftl-no-cjit-no-inline-validate
    stress/ftl-try-catch-oom-error-lazy-slow-path.js.ftl-no-cjit-no-put-stack-validate
    stress/ftl-try-catch-oom-error-lazy-slow-path.js.ftl-no-cjit-small-pool
    stress/ftl-try-catch-oom-error-lazy-slow-path.js.ftl-no-cjit-validate
    stress/ftl-try-catch-patchpoint-with-volatile-registers.js.default-ftl
    stress/ftl-try-catch-patchpoint-with-volatile-registers.js.ftl-eager-no-cjit
    stress/ftl-try-catch-patchpoint-with-volatile-registers.js.ftl-no-cjit-no-inline-validate
    stress/ftl-try-catch-patchpoint-with-volatile-registers.js.ftl-no-cjit-no-put-stack-validate
    stress/ftl-try-catch-patchpoint-with-volatile-registers.js.ftl-no-cjit-validate
    stress/load-varargs-then-inlined-call-and-exit-strict.js.ftl-no-cjit-no-inline-validate
    stress/op_negate.js.ftl-no-cjit
    stress/reflect-apply.js.ftl-eager-no-cjit
    stress/tail-call-varargs-no-stack-overflow.js.default-ftl
    stress/tail-call-varargs-no-stack-overflow.js.ftl-eager
    stress/tail-call-varargs-no-stack-overflow.js.ftl-eager-no-cjit
    stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-no-inline-validate
    stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-no-put-stack-validate
    stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-small-pool
    stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-validate
    stress/varargs-varargs-inlined-exit-strict-mode.js.ftl-no-cjit-no-inline-validate

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160108/ea5802be/attachment.html>