[Webkit-unassigned] [Bug 152900] New: Correct UNREACHABLE runtime assertion for void constructors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152900

            Bug ID: 152900
           Summary: Correct UNREACHABLE runtime assertion for void
                    constructors
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org
                CC: dino at apple.com

The fix is just to remove the UNREACHABLE call in this name mangler. Several expected values pass through here and should not contribute to the mangled name. The ‘UNREACHBLE()’ call was not appropriate:

chromium / angle / angle / 01971113492d9aca386f2bca021b1f4b134fc277^! / .
commit    01971113492d9aca386f2bca021b1f4b134fc277    [log] [tgz]
author    Dmitry Skiba <dskiba at google.com>    Fri Jul 10 18:54:00 2015
committer    Jamie Madill <jmadill at chromium.org>    Fri Jul 10 19:03:34 2015
tree    47e42eac00f7d64cddb14b3cc21a4e605c189d20
parent    53b76107ece2f5b4dfc831f2b571f9db04d65c73 [diff]

diff --git a/src/compiler/translator/Types.cpp b/src/compiler/translator/Types.cpp
index 0b60eb1..62bcd8e 100644
--- a/src/compiler/translator/Types.cpp
+++ b/src/compiler/translator/Types.cpp
@@ -142,7 +142,8 @@
         mangledName += interfaceBlock->mangledName();
         break;
       default:
-        UNREACHABLE();
+        // EbtVoid, EbtAddress and non types
+        break;
     }

     if (isMatrix())

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160108/7609fe63/attachment.html>