[Webkit-unassigned] [Bug 152345] Teach dashboard code to compare non-integer revisions.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 8 10:42:28 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=152345

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #268425|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #18 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 268425
  --> https://bugs.webkit.org/attachment.cgi?id=268425
2. Adding a unit test to test BuildbotQueueView._appendPendingRevisionCount.

Similar to my remarks in comment #17, I suggest that we either file a separate bug for this patch or combine this patch with the patch for adding QUnit (attachment #268424) and file a single bug for both. The benefit of the latter approach is that we directly convey the purpose of adding the QUnit framework as the means for supporting the effort to add a unit test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160108/db70a356/attachment.html>


More information about the webkit-unassigned mailing list