[Webkit-unassigned] [Bug 152830] [GTK] Cleanup ScrollbarThemeGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 8 07:58:02 PST 2016


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |mcatanzaro at igalia.com

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #4)
> You can ask any question without rejecting the patch.

I really was rejecting this version of the patch. ;) Because...

> The ScrollbarTheme methods are called either to get layout information
> (mainly scrollbarThickness) or to actually paint. Paint is the one calling
> all others (paintScrollbarBackground, paintTrackBackground, paintThumb,
> etc.). What I'm doing is caching the parent style context only for the
> paint() scope, to avoid creating new style contexts from any other method
> called from paint(). The style properties we cache are all properties of the
> parent scrollbar class.

...I did not understand that this cache existed only for the scope of paint(). This invalidates all of my concerns.

> No, GtkScrollbar inherits from GtkRange that implements GtkOrientable. See
> _gtk_orientable_set_style_classes(). There's indeed some specific CSS
> depending on the orientation for scrollbars in Adwaita, see:

Hm, a documentation issue then; the documentation for other widgets mentions this clearly.

> I had a previous version where I passed a state, this looks like a leftover.

OK. This is the only thing that needs fixed.

> This is the first call. Note that all other methods calling
> getOrCreateStyleContext() are not caching it, only paint is caching this
> context.

OK, I understand now.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160108/2d5daf14/attachment.html>

More information about the webkit-unassigned mailing list