[Webkit-unassigned] [Bug 152345] Teach dashboard code to compare non-integer revisions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152345

--- Comment #16 from Jason Marcell <jmarcell at apple.com> ---
(In reply to comment #9)
> (In reply to comment #7)
> > Comment on attachment 267593 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=267593&action=review
> > 
> > Looks good overall. Few things, but otherwise nice work... I know a lot of
> > people will be happy to see these changes merged. :)
> > 
> > Also, thanks for adding QUnit! It's awesome that we have a way to test our
> > front-end now.
> > 
> > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:301
> > >          var sortedRepositories = Dashboard.sortedRepositories;
> > >          for (var i = 0; i < sortedRepositories.length; ++i) {
> > >              var repositoryName = sortedRepositories[i].name;
> > > -            var result = b.revision[repositoryName] - a.revision[repositoryName];
> > > +            var trac = sortedRepositories[i].trac;
> > > +            if (!trac || b.revision[repositoryName] === undefined || a.revision[repositoryName] === undefined)
> > > +                return undefined;
> > > +            var result = trac.compareRevisions(b.revision[repositoryName], a.revision[repositoryName]);
> > >              if (result)
> > >                  return result;
> > >          }
> > 
> > Could compareIterations and compareIterationsByRevisions share this piece of
> > code? It looks identical.
> 
> Yes, both compareIterations and compareIterationsByRevisions are very
> similar. The latter was introduced here:
> https://bugs.webkit.org/show_bug.cgi?id=143885
> 
> We should probably find a way to collapse these into a single function if
> possible so that we are not duplicating code.

I have addressed this in its own patch. Please see the following:
https://bugs.webkit.org/attachment.cgi?id=268503&action=review

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160107/693bf218/attachment.html>