[Webkit-unassigned] [Bug 152664] [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152664

--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
(In reply to comment #7)
> Shouldn't JavaScriptCore_INCLUDE_DIRECTORIES be removed from
> PlatformWin.cmake instead?
No, it's needed because in PlatformWin.cmake we make jscLib, which isn't needed in non-windows ports.  jsc.exe is just a simple program that finds jscLib and starts it after possibly finding some other dlls.
I don't think it's critical to include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES on Windows.  It wouldn't hurt, but I don't think it's needed.  Commit this adding it to Windows or not, but don't remove JavaScriptCore_INCLUDE_DIRECTORIES from PlatformWin.cmake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160106/3bf325d3/attachment.html>