[Webkit-unassigned] [Bug 152664] [CMake] JSC shell sources should include JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152664

--- Comment #7 from Konstantin Tokarev <annulen at yandex.ru> ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > Comment on attachment 268140 [details]
> > > Added include_directories(JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES)
> > > 
> > > Sorry for breaking this!
> > > 
> > > I am going to give cq- since this same construct exists in PlatformWin.cmake
> > > in this directory. Please fix it there too!
> > 
> > I'm not building for Windows, but for me it seems like it includes
> > ${JavaScriptCore_INCLUDE_DIRECTORIES} twice, first time in CMakeLists.txt
> > and second time in PlatformWin.cmake. Other port don't do it
> 
> yes, we meant it needs to be fixed in this patch together.

Shouldn't JavaScriptCore_INCLUDE_DIRECTORIES be removed from PlatformWin.cmake instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160105/62c19e4d/attachment.html>