[Webkit-unassigned] [Bug 152677] New: [GTK] Fix -Wpessimizing-move warnings after switch to WTFMove

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 3 16:51:17 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=152677

            Bug ID: 152677
           Summary: [GTK] Fix -Wpessimizing-move warnings after switch to
                    WTFMove
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org

Now that we have switched from WTF::move to the macro WTFMove, we've triggered some good clang warnings that our use of WTF::move was hiding.

[1015/3230] Building CXX object Source...r/platform/glib/KeyedDecoderGlib.cpp.o
../../Source/WebCore/platform/glib/KeyedDecoderGlib.cpp:61:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move<WTF::CheckMoveParameter>(dictionary);
           ^
../../Source/WebCore/platform/glib/KeyedDecoderGlib.cpp:61:12: note: remove std::move call here
    return std::move<WTF::CheckMoveParameter>(dictionary);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~          ~
1 warning generated.
[1038/3230] Building CXX object Source...atform/graphics/egl/GLContextEGL.cpp.o
../../Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:212:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move<WTF::CheckMoveParameter>(context);
           ^
../../Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:212:12: note: remove std::move call here
    return std::move<WTF::CheckMoveParameter>(context);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~       ~
1 warning generated.
[1046/3230] Building CXX object Source...atform/graphics/glx/GLContextGLX.cpp.o
../../Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:139:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
    return std::move<WTF::CheckMoveParameter>(context);
           ^
../../Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:139:12: note: remove std::move call here
    return std::move<WTF::CheckMoveParameter>(context);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~       ~
1 warning generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160104/bc33cf59/attachment.html>


More information about the webkit-unassigned mailing list