[Webkit-unassigned] [Bug 146041] [GTK] Reimplement webkit_web_context_clear_cache functionality.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 3 15:41:36 PST 2016


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |gyuyoung.kim at webkit.org

--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #12)
> we need to fix this in 2.10 branch in any case.

My vote is to not bother. The GTK+ port does not use the soup cache anymore; only EFL does. I think EFL should switch to use the network cache (which will hopefully be painless) so that USE(SOUP) implies ENABLE(NETWORK_CACHE); then we can remove all our soup cache code. You already taught the network process to clear the soup cache on startup when the network cache is enabled, so we won't have to worry about it anymore.

In summary:

 * This patch's changes to WebKitWebContext.cpp are good as-is, r=me.
 * I do not particularly want the change to WebProcess.cpp in trunk.
    * That change is fine for the 2.10 branch, but you must be sure to change WebProcess::deleteWebsiteDataForOrigins as well; otherwise, the change is broken!
 * I am changing this to r+ on the basis that I have asked you to remove from this patch the change that Anders objected to when he gave this r-.

Sound good?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160103/1f0bc9a0/attachment-0001.html>

More information about the webkit-unassigned mailing list