[Webkit-unassigned] [Bug 152625] WebKit fails to build with musl libc library

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152625

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #268112|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 268112
  --> https://bugs.webkit.org/attachment.cgi?id=268112
patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=268112&action=review

> Source/JavaScriptCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=152625
> +        qualify isnan() calls with std namespace.

This ChangeLog entry does not conform to the format described in <https://webkit.org/contributing-code/#changelogs>. In particular, these two lines should be the bug title and bug URL in that order. The description (line 4) should be placed under the Reviewed by line and begin with a capital letter (Q). We should also explain in the description that the motivation of this change is to fix the build when building with the musl libc library on Linux. I also suggest that we omit the description of Option::operator== (line 9) because this ChangeLog only describes a change to a single function, Option::operator==, and the change description for Option::operator== (line 9) is almost the same as the description (line 4). Making the above changes, we have: 

2016-01-02 Khem Raj <raj.khem at gmail.com>

        WebKit fails to build with musl libc library
        https://bugs.webkit.org/show_bug.cgi?id=152625

        Reviewed by Daniel Bates.

        Qualify isnan() calls with std namespace to fix the build when building with the musl libc library on Linux.

        * runtime/Options.cpp:
        (Option::operator==):

> Source/WTF/ChangeLog:4
> +        Disable ctype.h check for musl C library on Linux.

Similar to my remarks for the ChangeLog entry in Source/JavaScriptCore/ChangeLog, please move this description under the Reviewed by line, change line 3 to the the bug title ("WebKit fails to build with musl libc library") and change line 4 to be bug URL (https://bugs.webkit.org/show_bug.cgi?id=152625).

> Source/WTF/ChangeLog:8
> +        * wtf/DisallowCType.h

Please add a colon character (:) at the end of this line to fix the style bot warning (*):

ERROR: Source/WTF/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]

(*) This error message is disingenuous. The actual error is that there is no colon character after the filename. We should teach the style bot to detect the omission of the ':' and provide a better error message. This work should be done in a separate bug.

> Source/WTF/ChangeLog:10
> +        Enable backtrace on linux when using glibc

linux => Linux

Please add a period to the end of this sentence.

(These are very small issues. As part of addressing the bug title/description corrections I suggest we also make these changes).

> Source/WTF/ChangeLog:11
> +        We dont have backtrace() implemented on non-glibc libc's on Linux.

dont => don't

(This is a very small issue. As part of addressing the bug title/description corrections I suggest we also make this change).

> Source/WTF/ChangeLog:13
> +        * wtf/Assertions.cpp

Please add a colon character (:) at the end of this line to fix the style bot warning (*):

ERROR: Source/WTF/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]

> Source/WTF/wtf/Assertions.cpp:71
> +#if OS(DARWIN) || (OS(LINUX) && defined(__GLIBC__) && !defined(__UCLIBC__))

For completeness, we must explicitly check for !defined(__UCLIBC__) (i.e. cannot check OS(LINUX) && defined(__GLIBC__)) because uClibc usually defines __GLIBC__ when being compiled per <https://git.uclibc.org/uClibc/tree/include/features.h?id=266bdc1f623fe6fe489e5115e0f8ef723705d949>. The criterion for defining __GLIBC__ and the motivation for doing so is described at <https://git.uclibc.org/uClibc/tree/include/features.h?id=266bdc1f623fe6fe489e5115e0f8ef723705d949#n81> and <https://git.uclibc.org/uClibc/tree/include/features.h?id=266bdc1f623fe6fe489e5115e0f8ef723705d949#n376>.

On another note, the musl libc project does not expose any preprocessor macros to identify the use of the musl libc library during compilation as a matter of policy (http://wiki.musl-libc.org/wiki/FAQ#Q:_why_is_there_no_MUSL_macro_.3F).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160103/408d6ba7/attachment.html>