[Webkit-unassigned] [Bug 150412] [MIPS] "(-1) % NaN" returns -1 instead of NaN with LLInt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150412

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263727|review+                     |review-
              Flags|                            |

--- Comment #4 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 263727
  --> https://bugs.webkit.org/attachment.cgi?id=263727
Patch

I think that this is the wrong approach. You should create a new header (JSMathExtras.h maybe) that provides an abstraction for fmod, and probably other things in the future. Then inside that abstraction you can do the purifyNaN based on some condition, like maybe a global switch like MATH_PURIFIES_NAN, which can be false on MIPS. This is a better approach because there will be other callers of fmod and there will be other math functions that have the same issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160102/05bac74d/attachment-0001.html>