[Webkit-unassigned] [Bug 128459] [GTK] Minibrowser: On opening search bar, search for selected text if any

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 2 09:31:36 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=128459

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223572|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 223572
  --> https://bugs.webkit.org/attachment.cgi?id=223572
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223572&action=review

Thanks for the review, Berto. Updating the flags to make it official and remove this from request queue....

> Tools/MiniBrowser/gtk/BrowserSearchBar.c:322
> +        g_free(selectedText);

Surely you need to free selectedText even if it's zero-length, since you allocated the memory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160102/00db6b31/attachment.html>


More information about the webkit-unassigned mailing list