[Webkit-unassigned] [Bug 154814] [GTK] webkitWebViewBaseRealize broken in Wayland with USE_OPENGL=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154814

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #3)
> It's not so simple, another problem is that in
> WebCore::PlatformDisplay::createPlatformDisplay,
> gdk_display_manager_get_default_display returns some non-null display for
> which neither GDK_IS_X11_DISPLAY nor GDK_IS_WAYLAND_DISPLAY is true

Well I couldn't explain that, so I thought about it a bit more, and actually it is returning a GdkDisplayWayland. The problem is that our Wayland support depends on OpenGL, and we have it baked into our build system to enforce this. I can see in our build logs:

-- Disabling ENABLE_3D_TRANSFORMS since ENABLE_OPENGL is disabled.
-- Disabling ENABLE_WAYLAND_TARGET since ENABLE_OPENGL is disabled.
-- Disabling ENABLE_WEBGL since ENABLE_OPENGL is disabled.
-- Disabling USE_REDIRECTED_XCOMPOSITE_WINDOW since ENABLE_OPENGL is disabled.

-- Enabled features:
--  ENABLE_ACCELERATED_2D_CANVAS ............ OFF
--  ENABLE_CREDENTIAL_STORAGE                 ON
--  ENABLE_DRAG_SUPPORT ..................... ON
--  ENABLE_GEOLOCATION                        ON
--  ENABLE_GLES2 ............................ OFF
--  ENABLE_GTKDOC                             ON
--  ENABLE_ICONDATABASE ..................... ON
--  ENABLE_INTROSPECTION                      ON
--  ENABLE_JIT .............................. ON
--  ENABLE_MEMORY_SAMPLER                     ON
--  ENABLE_MINIBROWSER ...................... ON
--  ENABLE_OPENGL                             OFF
--  ENABLE_PLUGIN_PROCESS_GTK2 .............. ON
--  ENABLE_QUARTZ_TARGET                      OFF
--  ENABLE_SAMPLING_PROFILER ................ ON
--  ENABLE_SPELLCHECK                         ON
--  ENABLE_TOUCH_EVENTS ..................... ON
--  ENABLE_VIDEO                              ON
--  ENABLE_WAYLAND_TARGET ................... OFF
--  ENABLE_WEB_AUDIO                          ON
--  ENABLE_X11_TARGET ....................... ON
--  USE_LIBHYPHEN                             ON
--  USE_LIBNOTIFY ........................... ON
--  USE_SYSTEM_MALLOC                         OFF

There is in fact no need to check if we're running under Wayland at those points in webkitWebViewBaseRealize/Unrealize, as they're unreachable if Wayland support is enabled. Nothing to change here, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160229/3ead46e1/attachment.html>