[Webkit-unassigned] [Bug 154814] [GTK] webkitWebViewBaseRealize broken in Wayland with USE_OPENGL=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154814

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com
            Summary|webkitgtk4-2.11.90-2.fc24   |[GTK]
                   |misrenders on wayland and   |webkitWebViewBaseRealize
                   |tries to use X11            |broken in Wayland with
                   |                            |USE_OPENGL=OFF

--- Comment #1 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #0)
> Might be related to the fact that Fedora 24 is built with ENABLE_OPENGL=off
> since the problem doesn't happen in rawhide with the same version (but has
> opengl enabled)

This code in webkitWebViewBaseRealize is wrong:

#if USE(TEXTURE_MAPPER) && PLATFORM(X11) && !USE(REDIRECTED_XCOMPOSITE_WINDOW)
    if (DrawingAreaProxyImpl* drawingArea = static_cast<DrawingAreaProxyImpl*>(priv->pageProxy->drawingArea()))
        drawingArea->setNativeSurfaceHandleForCompositing(GDK_WINDOW_XID(window));
#endif

You can see it improperly casts the GdkWindow to a GdkX11Window without checking to make sure it's X11. And I see it's guarded by USE(TEXTURE_MAPPER) so it's indeed not enabled by default, that explains why it works in rawhide (where I reenabled USE_OPENGL after our recent bugfixes) but not F24 (which I accidentally did not reenable USE_OPENGL until just now).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160229/c0cee8b2/attachment-0001.html>