[Webkit-unassigned] [Bug 153829] [GTK] Touch slider test fails due to assertion in webkitWebViewBaseTouchEvent()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153829

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272481|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 272481
  --> https://bugs.webkit.org/attachment.cgi?id=272481
Remove gesture sequence from touch sequence set

View in context: https://bugs.webkit.org/attachment.cgi?id=272481&action=review

You should remove the tests the pass now from the TestExpectations file.

> Source/WebKit2/ChangeLog:9
> +        Once a touch event sequence is identified as a gesture, remove it
> +        from the list of handled touch events.
> +
> +        Reviewed by NOBODY (OOPS!).

We normally add the description after the Reviewed by line.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:962
> +        if (priv->touchEvents.contains(sequence))
> +            priv->touchEvents.remove(sequence);

No need to check the sequence is in the map, remove() does nothing if not present.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160229/ca082f4b/attachment.html>