[Webkit-unassigned] [Bug 154742] Add support for playbackControlsManager

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154742

Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272362|review?                     |review+
              Flags|                            |

--- Comment #7 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 272362
  --> https://bugs.webkit.org/attachment.cgi?id=272362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272362&action=review

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:213
> +        double start = timeRanges.start(i, exceptionCode);
> +        double end = timeRanges.end(i, exceptionCode);
> +        
> +        CMTimeRange range = CMTimeRangeMake(CMTimeMakeWithSeconds(start, 1000), CMTimeMakeWithSeconds(end-start, 1000));
> +        [seekableRanges addObject:[NSValue valueWithCMTimeRange:range]];

You can use timeRanges.ranges() to get a PlatformTimeRanges. This object's start() and end()  methods don't take an exception code, and they return MediaTime objects.  So this would become:

const PlatformTimeRanges& ranges = timeRanges.ranges();
CMTimeRange range = CMTimeRangeMake(toCMTime(ranges.start(i)), toCMTime(ranges.end(i)));

> Source/WebCore/platform/spi/mac/AVFoundationSPI.h:35
> +#import <AVFoundation/AVTime.h>

AVTime.h should be available in the SDK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160226/b06e4f31/attachment.html>