[Webkit-unassigned] [Bug 154742] Add support for playbackControlsManager

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154742

--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 272360
  --> https://bugs.webkit.org/attachment.cgi?id=272360
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272360&action=review

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:179
> +    controlsManager.hasEnabledAudio = YES;
> +    controlsManager.hasEnabledVideo = YES;

This isn't necessarily correct, should it have a FIXME?

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:209
> +        double start = timeRanges.start(i, exceptionCode);
> +        double end = timeRanges.end(i, exceptionCode);

Can you use ASSERT_NO_EXCEPTION instead of ignoring potential exceptions?

> Source/WebKit2/UIProcess/mac/PageClientImpl.h:217
> +    virtual void isPlayingMediaDidChange() override;

Nit: "virtual" is implied with "override".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160226/a9e2211b/attachment.html>