[Webkit-unassigned] [Bug 153230] Network cache: old pages returned by disk cache on history navigation after session is restored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153230

--- Comment #44 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #43)
> Comment on attachment 271879 [details]
> Updated patch
> 
> Sorry, still not a huge fan of the complexity this adds. This seems
> intrusive and a bit complicated for what it does.
> 
> Would the following work?
> 1. We don't add a new load type (we already have too many)
> 2. We had a boolean flag to WebCore::HistoryItem to distinguish that the
> HistoryItem was restored from a previous session
> 3. We check this new WebCore::HistoryItem flag in
> FrameLoader::loadDifferentDocumentItem() to choose the right cache policy
> without requiring a new load type
> 4. We reset this flag right after it is read in
> FrameLoader::loadDifferentDocumentItem().
> 
> Let me know what you think.

This is pretty much what my first patch did :-) 

https://bug-153230-attachments.webkit.org/attachment.cgi?id=270655

I changed the approach because you were not sure about the need to add a member to HistoryItem, and I didn't like it either. See comment #12 :-)

But yes, I can go back to the initial approach, just with better names, with special case for iOS and resetting the flag. The patch was indeed a lot simpler.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160226/77297c01/attachment.html>