[Webkit-unassigned] [Bug 154444] [ThreadedCompositor] Opening the inspector in a window causes a crash.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154444

--- Comment #6 from ChangSeok Oh <changseok.oh at collabora.com> ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Created attachment 272106 [details]
> > > Patch
> > > 
> > > The threaded compositor doesn't handle the case of destroying the native
> > > surface handle and keeps using the GL context for the destroyed native
> > > surface. I think this patch also fixes bug #154071, since now when the web
> > > view is destroyed and unrealize method destroys the surface the threaded
> > > compositor correctly handles this case.
> > 
> > Thanks for this patch! I am also working on this though, you are faster than
> > me. =) At glance, your apporach looks pretty different from mine. I don't
> > have time to look into the detail now. I believe yoon will review the patch.
> > ;)
> 
> What approach were you following? It could be better than mine.

My idea is to destroy only the compositing thread and recreate it without touching others like glContext and CoordinatedGraphicsScene, I have a rough patch doing that, but it will take some more time until being ready to share. Let me share it with you when it is ready.
BTW, I am still seeing a crash even after applying your patch. Try to repeatedly open/close the inspector repeatedly by ctrl + shift + i or open/close it in a new window over again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160225/02a04ebd/attachment.html>