[Webkit-unassigned] [Bug 150955] [GTK] Tearing when entering AC mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150955

--- Comment #27 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #26)
> Comment on attachment 272003 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272003&action=review
> 
> Great changelog entry, I mostly understand what you are doing!
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1098
> > +    if (widgetIsOnscreenToplevelWindow(oldToplevel) && GTK_WINDOW(oldToplevel) == priv->toplevelOnScreenWindow) {
> 
> Surely GTK_WINDOW(oldToplevel) == oldToplevel so you don't need this cast?

It's not needed in C, but this is C++ and the compiler doesn't like comparing GtkWidget and GtkWindow pointers.

> > Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp:-71
> > -    gtk_widget_realize(viewWidget);
> 
> OK, I tested and there are no regressions related to bug #147453.

Great, thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160224/4be1cbe9/attachment.html>