[Webkit-unassigned] [Bug 150165] WebRTC: Add MediaEndpoint interface (WebRTC backend abstraction)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150165

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271795|review?                     |review+
              Flags|                            |

--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 271795
  --> https://bugs.webkit.org/attachment.cgi?id=271795
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271795&action=review

> Source/WebCore/ChangeLog:11
> +        configure the WebRTC backend how to send and receive. It also abstracts

Nit: "configure the WebRTC backend how to send and receive" -> something like "configure how the the WebRTC backend sends and receives"

> Source/WebCore/platform/mediastream/IceCandidate.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.

Nit: you might want to update this.

> Source/WebCore/platform/mediastream/IceCandidate.h:103
> +        : m_componentId(0)
> +        , m_priority(0)
> +        , m_port(0)
> +        , m_relatedPort(0)

These should be initialized in the class definition:

    unsigned m_componentId { 0 };
    int m_priority { 0 };

etc.

> Source/WebCore/platform/mediastream/MediaEndpoint.cpp:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.

Update?

> Source/WebCore/platform/mediastream/MediaEndpoint.cpp:40
> +    return nullptr;

Should this ASSERT?

> Source/WebCore/platform/mediastream/MediaEndpoint.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.

Update?

> Source/WebCore/platform/mediastream/MediaEndpointConfiguration.cpp:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.

Update?

> Source/WebCore/platform/mediastream/MediaEndpointConfiguration.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.

Update?

> Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.

Update?

> Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h:72
> +        : m_sessionId(cryptographicallyRandomNumber()) // FIXME: should be 64 bits

Can you initialize this by bit-shifting two random 32 bit numbers?

> Source/WebCore/platform/mediastream/MediaEndpointSessionConfiguration.h:73
> +        , m_sessionVersion(0)

This should be initialized in the class definition.

> Source/WebCore/platform/mediastream/MediaPayload.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.

Update?

> Source/WebCore/platform/mediastream/MediaPayload.h:102
> +        : m_type(0)
> +        , m_clockRate(0)
> +        , m_channels(0)
> +        , m_ccmfir(false)
> +        , m_nackpli(false)
> +        , m_nack(false)

These should be initialized in the class definition.

> Source/WebCore/platform/mediastream/PeerMediaDescription.h:2
> + * Copyright (C) 2015 Ericsson AB. All rights reserved.

Update?

> Source/WebCore/platform/mediastream/PeerMediaDescription.h:154
> +        : m_port(0)
> +        , m_rtcpMux(false)
> +        , m_rtcpPort(0)
> +        , m_source(nullptr)

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160223/3552eacd/attachment.html>