[Webkit-unassigned] [Bug 154535] Workaround for ICE in GCC 4.8 appeared in r196846.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154535

--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
(In reply to comment #6)
> Comment on attachment 271923 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271923&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> The change log does not explain why this should be "off" instead of off. It
> seems valid to use off without quotes to me. It should end up calling:
> inline bool equalIgnoringASCIICase(const AtomicString& a, const String& b);

I don't think we do have a equalIgnoringASCIICase() overload that takes a literal. Therefore, if you pass "off" it likely calls:
inline bool equalIgnoringASCIICase(const String& a, const char* b);

Which means we don't know the length of b in advance. If we pass a String in, the size of b is known in advance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160222/c51d0472/attachment.html>