[Webkit-unassigned] [Bug 154516] [JSC shell] Don't put empty arguments array to VM.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154516

--- Comment #3 from Konstantin Tokarev <annulen at yandex.ru> ---
(In reply to comment #2)
> Comment on attachment 271884 [details]
> Patch
> 
> I don't think the current approach is good because we would like to assume
> that there is an empty `arguments` if the CLI does not pass any arguments.
> 
> How about the following idea?
> 1. adding an Option (see runtime/Options.h), that controls exposing the
> `arguments`. Now, we can control this behavior with the environment variable
> JSC_XXX (If you add an option XXX, we can switch it with the environment
> variable JSC_XXX)
> 3. adding a ruby function notExposeArguments() in run-jsc-stress-tests,
> which defines JSC_XXX environment variable before executing the command.
> (Let's define addEnvVar(X, Y). And calling it as def notExposeArguments
> addEnvVar("JSC_XXX", "true"))
> 4. defining the annotation "//@ notExposeArguments" instead of "//@ skip"

Problem is that I use run-layout-jsc, which does not support annotations, and my initial motivation for this change was to allow this test to pass without @ skip annotation.

Though run-layout-jsc may unconditionally use this mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160222/30a905d9/attachment.html>