[Webkit-unassigned] [Bug 154516] [JSC shell] Don't put empty arguments array to VM.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 03:15:21 PST 2016


--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 271884
  --> https://bugs.webkit.org/attachment.cgi?id=271884

I don't think the current approach is good because we would like to assume that there is an empty `arguments` if the CLI does not pass any arguments.

How about the following idea?
1. adding an Option (see runtime/Options.h), that controls exposing the `arguments`. Now, we can control this behavior with the environment variable JSC_XXX (If you add an option XXX, we can switch it with the environment variable JSC_XXX)
3. adding a ruby function notExposeArguments() in run-jsc-stress-tests, which defines JSC_XXX environment variable before executing the command. (Let's define addEnvVar(X, Y). And calling it as def notExposeArguments addEnvVar("JSC_XXX", "true"))
4. defining the annotation "//@ notExposeArguments" instead of "//@ skip"

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160222/7fe55ca1/attachment.html>

More information about the webkit-unassigned mailing list