[Webkit-unassigned] [Bug 154486] Improvements to Intl code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154486

--- Comment #8 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
(In reply to comment #7)
> Comment on attachment 271840 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271840&action=review
> 
> > Source/JavaScriptCore/runtime/IntlCollator.cpp:329
> > +    auto collator = std::unique_ptr<UCollator, UCollatorDeleter>(ucol_open(m_locale.utf8().data(), &status));
> 
> Use std::make_unique from StdLibExtras.h

I don't think that works, because ucol_open is not a C++ constructor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160221/77079552/attachment-0001.html>