[Webkit-unassigned] [Bug 154507] New: Use of inlined asm statements causes problems for -std=c99 builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154507

            Bug ID: 154507
           Summary: Use of inlined asm statements causes problems for
                    -std=c99 builds
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

WTF's Assertions.h may inadvertantly get included by other projects that are built with -std=c99.  The use of the inlined asm statements with the keyword "asm" is not recognized when the -std compiler flag is used.  https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html says "When writing code that can be compiled with -ansi and the various -std options, use __asm__ instead of asm (see Alternate Keywords)."

So, to be a good citizen, we can change the use of "asm" in CRASH() to "__asm__" so that we don't break the build of such other projects.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160221/f11b892f/attachment.html>