[Webkit-unassigned] [Bug 154450] [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 20 08:26:38 PST 2016


--- Comment #7 from Konstantin Tokarev <annulen at yandex.ru> ---
(In reply to comment #6)
> I think the value of moving this duplicate code to a macro probably
> outweighs the value of being explicit, so I'm OK with this.

It seems to me that there is established set of "standard" variables for each WebKit target that configure it. So this patch would not only reduce code size, but would also help to make target behavior more consistent in future. I'm planning to submit similar patches for binaries and non-framework libraries.

Also, it would simplify addition of new configurable properties, e.g. in Qt port we would like to override precompiled header files via variables like WebCore_PRECOMPILED_HEADER.

 I want to give
> Alex and Martin a chance to chime in, though.
> I'm not sure about getting rid of WebKit2_DERIVED_SOURCES, because I think
> we might want to set different CPPFLAGS there to silence some warnings we
> currently have. And Alex has a patch introducing WebCore_DERIVED_SOURCES in
> bug #151399.

Note that he adds WebCore_DERIVEDSOURCES, not WebCore_DERIVED_SOURCES, breaking "convention" of WebKit2. If we really need to use different flags on derived sources, I will add ${${_target}_DERIVED_SOURCES} to source list of target.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160220/f93930ba/attachment.html>

More information about the webkit-unassigned mailing list