[Webkit-unassigned] [Bug 154450] [cmake] Moved library setup code to WEBKIT_FRAMEWORK macro.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 20 08:12:50 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=154450

--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 271860
  --> https://bugs.webkit.org/attachment.cgi?id=271860
Patch

I think the value of moving this duplicate code to a macro probably outweighs the value of being explicit, so I'm OK with this. I want to give Alex and Martin a chance to chime in, though.

I'm not sure about getting rid of WebKit2_DERIVED_SOURCES, because I think we might want to set different CPPFLAGS there to silence some warnings we currently have. And Alex has a patch introducing WebCore_DERIVED_SOURCES in bug #151399.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160220/238f2515/attachment.html>


More information about the webkit-unassigned mailing list