[Webkit-unassigned] [Bug 154486] New: Improvements to Intl code
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 19 18:24:25 PST 2016
https://bugs.webkit.org/show_bug.cgi?id=154486
Bug ID: 154486
Summary: Improvements to Intl code
Classification: Unclassified
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: JavaScriptCore
Assignee: webkit-unassigned at lists.webkit.org
Reporter: sukolsak at gmail.com
- Use std::unique_ptr to store ICU objects (See Comment 10 in https://bugs.webkit.org/show_bug.cgi?id=147603#c10)
- Pass Vector::size() to ICU functions that take a buffer size instead of Vector::capacity()
- If U_SUCCESS(status) is true, it means there is no error, but there could be warnings. ICU functions ignore warnings. So, there is no need to reset status to U_ZERO_ERROR.
- Remove the initialization of the String instance variables of IntlDateTimeFormat. These values are never read and cause unnecessary memory allocation.
- Fix coding style
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160220/696fa406/attachment.html>
More information about the webkit-unassigned
mailing list