[Webkit-unassigned] [Bug 154333] Add test to check scroll animator events after a history navigation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 08:22:28 PST 2016


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #271541|review?                     |review-
              Flags|                            |

--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 271541
  --> https://bugs.webkit.org/attachment.cgi?id=271541

View in context: https://bugs.webkit.org/attachment.cgi?id=271541&action=review

Looks good, except for the WK1 test failure that needs fixed.

> LayoutTests/fast/scrolling/scroll-animator-events-after-history-navigation.html:31
> +          delete sessionStorage.didNavigate;

Why do you need to do this? The test is about to end!

> LayoutTests/fast/scrolling/scroll-animator-events-after-history-navigation.html:37
> +          sessionStorage.didNavigate = true;

This is needed... why, so that the page enters the page cache?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160219/3f4f20ec/attachment.html>

More information about the webkit-unassigned mailing list