[Webkit-unassigned] [Bug 154417] New: Possibly incorrect check-webkit-style complaint.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154417

            Bug ID: 154417
           Summary: Possibly incorrect check-webkit-style complaint.
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: krollin at apple.com
                CC: lforschler at apple.com

In Bug 154148, check-webkit-style complains about a multi-line macro.

ERROR: Source/WTF/wtf/Assertions.h:458:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WTF/wtf/Assertions.h:464:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 71 files

Here is code associated with the second of the two errors.

#define RELEASE_ASSERT_WITH_MESSAGE(assertion, format, ...) do { \
    if (UNLIKELY(!(assertion))) { \
        LOG_ALWAYS_WITH_STRINGS("Assertion failed: %s : " format, #assertion, ##__VA_ARGS__); \
        CRASH(); \
    } \
} while (0)

This macro looks fine to me. I'm not clear on what check-webkit-style is complaining about.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160218/1376319a/attachment.html>