[Webkit-unassigned] [Bug 154312] AX: Implement sentence related text marker functions using TextIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154312

--- Comment #4 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 271497
  --> https://bugs.webkit.org/attachment.cgi?id=271497
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271497&action=review

>> Source/WebCore/accessibility/AXObjectCache.cpp:1741
>> +            if (charOffset.offset == offset)
> 
> do we have a test case covering this now?

Yes, it's covered in the sentence navigation.

>> Source/WebCore/accessibility/AXObjectCache.cpp:2122
>> +    // We don't want to go to the previous node.
> 
> can you add why

Ok.

>> Source/WebCore/accessibility/AXObjectCache.cpp:2193
>> +    if (!next.isNull() && next.node->hasTagName(brTag) && !characterOffset.node->hasTagName(brTag))
> 
> can you put this if into a static method. looks like you use it here and below

Ok.

>> Source/WebCore/accessibility/AXObjectCache.cpp:2230
>> +    // make sure we move off of a sentence end
> 
> full sentence

Ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160217/1618fd20/attachment-0001.html>