[Webkit-unassigned] [Bug 154287] Factor id mutation style invalidation code into a class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154287

Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #271427|review?                     |review+
              Flags|                            |

--- Comment #2 from Andreas Kling <akling at apple.com> ---
Comment on attachment 271427
  --> https://bugs.webkit.org/attachment.cgi?id=271427
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271427&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        However dynamic id changes are not common enought (nor recommended) to pay the memory cost of
> +        the required data structures.

Strongly agree with this.
Also s/enought/enough/

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:10555
> -		83D35AEF1C718D8400F70D5A /* JSXMLHttpRequestEventTarget.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSXMLHttpRequestEventTarget.cpp; path = JSXMLHttpRequestEventTarget.cpp; sourceTree = "<group>"; };
> -		83D35AF01C718D8400F70D5A /* JSXMLHttpRequestEventTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSXMLHttpRequestEventTarget.h; path = JSXMLHttpRequestEventTarget.h; sourceTree = "<group>"; };
> +		83D35AEF1C718D8400F70D5A /* JSXMLHttpRequestEventTarget.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSXMLHttpRequestEventTarget.cpp; sourceTree = "<group>"; };
> +		83D35AF01C718D8400F70D5A /* JSXMLHttpRequestEventTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSXMLHttpRequestEventTarget.h; sourceTree = "<group>"; };
>  		83E359A01BB1031D002CEB98 /* JSHTMLTimeElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSHTMLTimeElement.h; sourceTree = "<group>"; };

I don't know what these are about.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/2afe05fb/attachment-0001.html>