[Webkit-unassigned] [Bug 154285] [GStreamer] clean-up various leaks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 16 06:04:02 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=154285

--- Comment #3 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 271425 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271425&action=review
> 
> > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:196
> > +    priv->task = adoptGRef(gst_task_new(reinterpret_cast<GstTaskFunction>(webKitWebAudioSrcLoop), src, 0));
> 
> GstTask is GInitiallyUnowned, so this returns a floating reference that we
> should consume here, so adoptGRef is not correct. Aren't you hitting the
> assert in GRefPtr<GstTask> adoptGRef(GstTask* ptr) ?

Heh. No :)
But I'll double-check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/830fecc2/attachment.html>


More information about the webkit-unassigned mailing list