[Webkit-unassigned] [Bug 154235] [GTK][GStreamer] ClearKey EME v1 decryption support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154235

--- Comment #13 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 271332
  --> https://bugs.webkit.org/attachment.cgi?id=271332
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271332&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitCommonEncryptionDecryptorGStreamer.cpp:210
>> +    protectionMeta = reinterpret_cast<GstProtectionMeta*>(gst_buffer_get_protection_meta(buffer));
> 
> Why reinterpret cast? What does gst_buffer_get_protection_meta returns? a GstMeta*? I would make protectionMeta a GstMeta* instead and we don't need all the casts

We need a GstProtectionMeta because we use its info GstStructure below, which the base GstMeta struct doesn't have.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/2a1648d9/attachment.html>