[Webkit-unassigned] [Bug 154235] [GTK][GStreamer] ClearKey EME v1 decryption support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 15 23:40:35 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=154235

--- Comment #11 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > 
> > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:896
> > > > +    if (!equalIgnoringASCIICase(keySystem, "org.w3.clearkey"))
> > > > +        return MediaPlayer::KeySystemNotSupported;
> > > 
> > > Instead of duplication this check here, we could call supportsKeySystem
> > > instead, or move this check to a helper function and use it from both places.
> > > 
> > 
> > I'm not sure it's worth.
> 
> If the condition changes for whatever reason you will have to change it
> everywhere.
> 

In two places. I know we are lazy developers, but this is not worth the refactoring effort at this point, imho :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/c611b568/attachment.html>


More information about the webkit-unassigned mailing list