[Webkit-unassigned] [Bug 115363] [GTK] clicking on the scrollbar trough steps rather than jumps to the clicked position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115363

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270996|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 270996
  --> https://bugs.webkit.org/attachment.cgi?id=270996
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270996&action=review

Looks great

> Source/WebCore/ChangeLog:8
> +        Allow RenderTheme to decide the behavior of a button press event,

RenderTheme -> ScrollbarTheme

> Source/WebCore/ChangeLog:15
> +        (WebCore::Scrollbar::mouseDown): Ask RenderTheme to handle the

Ditto.

> Source/WebCore/platform/Scrollbar.cpp:396
> +    if (action == ScrollbarButtonPressAction::None)

Eh... on the one hand, it's probably the best solution.

On the other hand, it's not great that policy is decided by a class called "theme." Did you consider having Scrollbar::platformHandleMousePressEvent and adding new files for each port just to implement that; it's a bit more work, but this is platform after all.

On the other other hand, shouldCenterOnThumb is already there, and maybe the logic is tied so closely to the theme it's just the best place. So whatevs.

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:449
> +        break;

Fix this unreachable break

> Source/WebCore/platform/win/ScrollbarThemeWin.cpp:209
> +        break;

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160216/bbc28eaa/attachment.html>