[Webkit-unassigned] [Bug 151442] Selection.deleteFromDocument should not leave a selection character

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 15 13:00:10 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=151442

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265957|review?                     |review+
              Flags|                            |

--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 265957
  --> https://bugs.webkit.org/attachment.cgi?id=265957
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265957&action=review

I see you've opened bug #151488 to address Darin's concerns about the new test crashing in debug builds, so I think this is fine for now, since it fixes a crash in release builds, adds a new test, cleans up an existing test, and matches the behavior of IE/FF/Blink.

> LayoutTests/editing/selection/deleteFromDocument.html:36
> +r.setEnd(span2.firstChild, 3);

Can you explain why you changed this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160215/851c0bd4/attachment.html>


More information about the webkit-unassigned mailing list