[Webkit-unassigned] [Bug 153404] REGRESSION(r188659): Non main frame scrollable areas don't work for pages restored from the page cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153404

--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
(In reply to comment #8)
> Comment on attachment 271347 [details]
> Different WIP approach
> 
> Seems reasonable, but you should make sure that you can actually get back to
> the FrameView in these two destructors (might be too late).

Disconnecting destroyed renderers from the FrameView seems like a good thing to be doing. So if this changes fixes your problem, without reintroducing the issues from Bug 148182, then I'm in favor of it.

However, I don't really like that various Render elements have to do work to keep things in proper balance. E.g., RenderListBox and RenderLayer have cleanup code, now DeprecatedPDFPlugin will have special code. Are there others we are missing?

Should ScrollableAreas know about their containing frames, so they can unregister themselves during destruction, rather than doing so in the individual destructors for ScrollableArea descendants?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160215/94b0b144/attachment-0001.html>