[Webkit-unassigned] [Bug 154082] Web Inspector: In the styles sidebar, Option-clicking on --css-variable should jump to its definition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154082

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 271274
  --> https://bugs.webkit.org/attachment.cgi?id=271274
[WIP] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271274&action=review

> Source/WebInspectorUI/ChangeLog:3
> +        Web Inspector: In the styles sidebar, Option-clicking on --css-variable should jump to its definition

This will require some thought.

Technically, CSS variables, being properties, have an overriding cascade. For example:

    <style>
    :root { --my-color: blue; }
    div { --my-color: red; }
    .foo { color: var(--my-color); }
    </style>
    <div class="foo">Red</div>
    <p class="foo">Blue</p>

However, I think in practice most variables will be global.

This patch doesn't handle re-definitions properly. Perhaps that isn't required for a first take on the feature though. But ideally we would know and jump to precisely the appropriate --var declaration that applies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160213/5127625c/attachment-0001.html>